Forward port config file setup from connector #5
Conversation
|
|
||
| .. code-block:: ini | ||
|
|
||
| [options-queue_job] |
There was a problem hiding this comment.
I wonder if mixing - and _ wouldn't bring some confusion for users. I understand that queue_job represents the name of the addon, but maybe options-queue-job would be simpler? What do you think?
There was a problem hiding this comment.
So, I originally made the section be called [options-connector] because I thought anybox.recipe.odoo could only make sections that were called [options-something].
Today, while pondering your question, I decided to see how hard it would be to change anybox to create any kind of section name, and then I realised I was mistaken, and actually it's possible to create any section name.
So I just rewrote the section name to simply [queue_job], while keeping backward compatibility with the old connector section name.
leorochael
force-pushed
the
10.0-add-queue_job-config-file
branch
from
6d01367
to
13033cf
Compare
In addition to the ODOO_CONNECTOR_CHANNELS environment variable, for
backward compatibility, we can configure the runner channels through
the ODOO_QUEUE_JOB_CHANNELS and in the odoo configuration file like this:
[options-job_queue]
channels = root:4
For backward compatibility, the section `[options-connector]` is also
accepted.
Moreover, it's now also possible to preload the module in the config
file, like:
[options]
server_wide_modules = web,web_kanban,queue_job
As such we can configure the job runner using only the Odoo config file.
Ignore whitespace around values, and tolerate missing entries that would be caused by trailing commas or commented lines when the channel configuration is provided through the Odoo configuration file. Also, accept line breaks channel entry separators along with commas, which make the configuration file more readable.
leorochael
force-pushed
the
10.0-add-queue_job-config-file
branch
from
13033cf
to
25315f0
Compare
|
Speaking of backward compatibility, There's a reference left to an Would you like it to be changed into And finally, should we keep backward compatibility with these old |
|
I don't mind if we forsake the backward compatibility as we change the Odoo version and many things around. But if you think it eases the transition to keep the |
It would be great :) |
Or replace them with references to queue_job. Also, rip off the barely useful modicum of backward compatibility.
@guewen, I agree. configurations will have to be changed, at the very least, to load the correct module (not to mention the fact that model names changed, and a migration would need to be very well thought out anyway), so I don't see much value in the feeble attempts at backward compatibility we have so far. So I added a commit removing all references and explicit backward compatibility with connector. |
|
Very nice, thanks |
|
No problem! Thanks for the merge! |
Forward port of OCA/connector#213.