Merge pull request #759 from gugod/ci-perl-5.8

testing with perl 5.8 in CI
gugod · Aug 4, 2022 · 83dd660 · 83dd660
2 parents ca448a0 + c7bfa2d
commit 83dd660
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 8 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -22,19 +22,31 @@ jobs:
           tool_name: perlnitpick
 
   yath:
-    runs-on: ${{ matrix.os }}
+    runs-on: ubuntu-latest
     strategy:
       matrix:
-        os: ['ubuntu-18.04']
         perl: [ '5.36', '5.34' ]
-    name: Perl ${{ matrix.perl }} on ${{ matrix.os }}
+    container:
+      image: perl:${{ matrix.perl }}
+    name: Perl ${{ matrix.perl }}
     steps:
       - uses: actions/checkout@v2
-      - name: Set up perl
-        uses: shogo82148/actions-setup-perl@v1
-        with:
-          perl-version: ${{ matrix.perl }}
       - run: perl -V
       - run: cpanm --quite --notest --installdeps .
       - run: cpanm --quite --notest App::Yath
       - run: yath test --qvf t/
+
+  prove:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        perl: [ '5.8', '5.10' ]
+    container:
+      image: perl:${{ matrix.perl }}
+    name: Perl ${{ matrix.perl }}
+    steps:
+      - uses: actions/checkout@v2
+      - run: perl -V
+      - run: cpanm --quite --notest --installdeps .
+      - run: cpanm --quite --notest App::Prove
+      - run: prove -lrv t
diff --git a/lib/App/perlbrew.pm b/lib/App/perlbrew.pm
@@ -2666,7 +2666,7 @@ sub list_modules {
         "TAP::Harness::Multiple" => "TAP::Harness::ReportByDescription",
     );
 
-    return [map { $rename{$_} // $_ } grep { $_ ne "Perl" } split( /\n/, $stdout )];
+    return [map { $rename{$_} || $_ } grep { $_ ne "Perl" } split( /\n/, $stdout )];
 }
 
 sub run_command_list_modules {