Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up global filehandles and fix a spelling error #246

Merged
merged 2 commits into from
Oct 9, 2012
Merged

Clean up global filehandles and fix a spelling error #246

merged 2 commits into from
Oct 9, 2012

Conversation

friedo
Copy link
Contributor

@friedo friedo commented Oct 9, 2012

EOM.

gugod added a commit that referenced this pull request Oct 9, 2012
Clean up global filehandles and fix a spelling error
@gugod gugod merged commit 0934f76 into gugod:develop Oct 9, 2012
@gugod
Copy link
Owner

gugod commented Oct 9, 2012

@friedo Thank you very much for the work. Just out of my curiosity, what makes you want to change those file handles ? Are you running into any issues ?

@friedo
Copy link
Contributor Author

friedo commented Oct 9, 2012

Nothing in particular - I was just looking through the code and spotted
them, so I thought I'd send a fix for best-practices purposes.

I'm also working on some fixes for better handling of perls with old-style
version numbers (e.g. perl5.005_04) which currently won't install at all.
That will take a little more work but hopefully I can send you another pull
request soon. :)

Mike

On Tue, Oct 9, 2012 at 2:13 PM, Kang-min Liu notifications@github.comwrote:

@friedo https://github.com/friedo Thank you very much for the work.
Just out of my curiosity, what makes you want to change those file handles
? Are you running into any issues ?


Reply to this email directly or view it on GitHubhttps://github.com//pull/246#issuecomment-9272801.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 752cece on friedo:develop into * on gugod:develop*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants