'perlbrew use' should not break the user's shell #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting bash subshells with --norc breaks the users shell setup and seems unecessary. The --profile option is also unecessary since a non-login shell is being started anyways.
|
Here's a screen grab showing what I'm referring to. Notice that my prompt (among other things) is completely busted in the perlbrew subshell:
|
gugod
added a commit
that referenced
this pull request
Jan 20, 2015
'perlbrew use' should not break the user's shell
jsonn
pushed a commit
to jsonn/pkgsrc
that referenced
this pull request
Feb 4, 2015
-------------- 0.73: # 2015-02-01T09:59:45+0100 - fixes and improvements from Manuel Streuhofer, Aristotle Pagaltzis, Sebastian Willert, David Hand, Eric Enns, Peter Roberts, Thomas Sibley, Ivan Baidakou, thanks! - fix 'perlbrew user' for fish users gugod/App-perlbrew#429 - fix sub-shell for bash users gugod/App-perlbrew#435 - clarify the 'perlbrew use' output: gugod/App-perlbrew#439
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting bash subshells with --norc breaks the users shell setup and
seems unecessary. The --profile option is also unecessary since a
non-login shell is being started anyways.