Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exec: do not exclude aliases whet they are specified in --with #731

Merged
merged 4 commits into from
Nov 22, 2021
Merged

exec: do not exclude aliases whet they are specified in --with #731

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6e5beb1
exec: do not exclude aliases whet they are specified in `--with`
gugod Nov 20, 2021
3f5b51c
updates of changelog
gugod Nov 21, 2021
ed6b74a
Merge branch 'develop' into exec-run-with-alias-when-specified
gugod Nov 21, 2021
04f1251
indentation.
gugod Nov 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Changes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
- Let `clone-modules` takes just one arguments and mean 'cloning modules from that perl'.
- Let `list-modules` and `clone-modules` map certain output to their representative module name. Github issue #722
- `exec` command now takes aliases explicitly specified in `--with` args and run commands with those aliases -- even if that would run the same thing twice. Github issue #725

0.92
- Released at 2021-04-15T23:53:55+0900
Expand Down
5 changes: 3 additions & 2 deletions lib/App/perlbrew.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2304,7 +2304,9 @@ sub run_command_exec {
@exec_with = map { $installed{$_} } @with;
} else {
@exec_with = map { ($_, @{$_->{libs}}) } $self->installed_perls;
@exec_with = grep {
not -l $self->root->perls( $_->{name} ); # Skip Aliases
} map { ($_, @{$_->{libs}}) } $self->installed_perls;
}
if ($opts{min}) {
Expand All @@ -2328,7 +2330,6 @@ sub run_command_exec {
my $overall_success = 1;
for my $i ( @exec_with ) {
next if -l $self->root->perls ($i->{name}); # Skip Aliases
my %env = $self->perlbrew_env($i->{name});
next if !$env{PERLBREW_PERL};
Expand Down