unset NO_COLOR env var when building. #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting NO_COLOR=1 would lead to test failures for a few modules in corelist. This var changes the behaviour of Term::ANSIColor module in corelist since version 5.01 and make it produce no colors code at all. the "podlator" moduled included in perl dist contain tests that verifies the existence of certain color codes and therefore would break when NO_COLOR is set. see also: #737
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting NO_COLOR=1 would lead to test failures for a few modules in corelist.
This var changes the behaviour of Term::ANSIColor module in corelist
since version 5.01 and make it produce no colors code at all.
the "podlator" moduled included in perl dist contain tests that
verifies the existence of certain color codes and therefore would
break when NO_COLOR is set.
see also: #737
Fixes #737