Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let install hint the user to do init. #751

Merged
merged 3 commits into from
Jul 24, 2022
Merged

Conversation

gugod
Copy link
Owner

@gugod gugod commented Jul 21, 2022

... if PERLBREW_ROOT is missing.

Fixes RT-57669

When perlbrew install $something is run before PERLBREW_ROOT (~/perl5) is made, now it should show the following error message to kindly request user to run perlbrew initonce

# PERLBREW_ROOT=/tmp/nonexist perlbrew install perl-5.37.2
ERROR: perlbrew root /tmp/nonexist does not exist. Run `perlbrew init` to prepare it first.

lib/App/perlbrew.pm Outdated Show resolved Hide resolved
Since it would errro when PERLBREW_ROOT is missing, we need to ensure
PERLBRE_ROOT exist if we intend to run `install`  in the test code.
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.05%) to 77.978% when pulling ba06b6c on rt-57669-install-check into b6d6433 on develop.

@gugod gugod merged commit d7ea2e8 into develop Jul 24, 2022
@gugod gugod deleted the rt-57669-install-check branch July 24, 2022 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants