Display non-200 response as error. #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove manual JSON construction as it
is decoded in the caller anyway and
it also needs to be properly escaped
which is an unnecessary hassle.
Optionally show the JSON decoding errors if
ELASTIJK_DEBUG is set.
Use localhost everywhere instead of 127.0.0.1. Give the test index a more definitive name.
…rgument.
The code traveling between Elastijk & Elastik::oo makes this a bit awkward.
The construct - @{$args}{qw(index type id)} - autovivifies, hence the breakdown of that section.
We also need to skip index and path parameters for version checks. The caller code
might set those during the object construction.
ES version 5 also removed search_type=scan
|
Hmmm.. This turned out to be a can of worms with the API changes after ES v5 |
|
This needs to be rethought / reworked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove manual JSON construction as it
is decoded in the caller anyway and
it also needs to be properly escaped
which is an unnecessary hassle.
Optionally show the JSON decoding errors if
ELASTIJK_DEBUG is set.