-
Notifications
You must be signed in to change notification settings - Fork 8
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
following the discussion at 15c655c#diff-4d52833b8aa64cefe7650fe92f375da4R110 we decided that dying on socket errors (SO_ERROR) is OK. However, then it makes it difficult to properly test a "connect timeout". So we update the test suite accordingly to accomodate the fact that, on some platforms, we die on socket errors (eg, No route to host), on others, it becomes a connection timeout. The platform-dependent behaviour feels odd, but packing one type of error into other type of errors is not better.
- Loading branch information
Showing
2 changed files
with
20 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters