-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add META.* and Build.PL #26
Conversation
Add stuff generated by mbtiny to allow installing with `cpanm` and friends by referring to the Git repository directly, e.g. $ cd Hijk $ cpanm . or even $ cpanm git://github.com/gugod/Hijk.git
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the initiative. Looks mostly good to me ! If you could fix the issues messy characters, I'll merged this PR 👍
META.json
Outdated
"author" : [ | ||
"=over 4", | ||
"=item Kang-min Liu <gugod@gugod.org>", | ||
"=item ÃÂvar Arnfjörð Bjarmason <avar@cpan.org>", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any idea why Ævar's name becomes a mess ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review!
Looks like this is due to
Lines 718 to 731 in 2804423
=head1 AUTHORS | |
=over 4 | |
=item Kang-min Liu <gugod@gugod.org> | |
=item Ævar Arnfjörð Bjarmason <avar@cpan.org> | |
=item Borislav Nikolov <jack@sofialondonmoskva.com> | |
=item Damian Gryski <damian@gryski.com> | |
=back | |
Which in turn App::ModuleBuildTiny::Dist tries to parse in https://github.com/Leont/app-modulebuildtiny/blob/74275cf4f9b7260b0c5496dc9ac6c098f6748dc9/lib/App/ModuleBuildTiny/Dist.pm#L130-L131 (through https://metacpan.org/pod/Module::Metadata.)
There are two problems here:
- extra pod is included
- App::ModuleBuildTiny::Dist doesn't seem to emit files in Unicode (considering
Hijk.pm
is already in Unicode and the pod is explicitly set=encoding utf8
)
For the first problem, an easy fix might be just to reformat the AUTHORS
pod to something like this:
=head1 AUTHORS
Kang-min Liu <gugod@gugod.org>
Ævar Arnfjörð Bjarmason <avar@cpan.org>
Borislav Nikolov <jack@sofialondonmoskva.com>
Damian Gryski <damian@gryski.com>
=cut
The second problem seems an issue in App::ModuleBuildTiny::Dist itself, so I think I can raise an issue there and link to this. Meanwhile, I can change this file here directly to unmunge Ævar's name.
Reformat so Module::Metadata (and authoring tools on top) can read it in without extra pod.
It seems that `mbtiny generate` writes without setting the right encoding, leading to Ævar's name getting munged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ! 👍
Thanks too! 🎉 |
This PR is a submission for my CPAN Pull Request Challenge this month.
Add stuff generated by mbtiny to allow installing with
cpanm
and friends by referring to the Git repository directly, e.g.or even