Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Application.RunState must be responsible for dispose the Toplevel property. #2985

Closed
BDisp opened this issue Nov 13, 2023 · 0 comments · Fixed by #2986
Closed

Application.RunState must be responsible for dispose the Toplevel property. #2985

BDisp opened this issue Nov 13, 2023 · 0 comments · Fixed by #2986
Labels
bug v1 For Issues & PRs targetting v1.x

Comments

@BDisp
Copy link
Collaborator

BDisp commented Nov 13, 2023

The Application.End method must only dispose the runState instance and not doing all the job of the Application.RunState class that must be responsible to do it.
The Application.Shutdown method must only freeing all the objects that aren't yet disposed.
BDisp added a commit to BDisp/Terminal.Gui that referenced this issue Nov 13, 2023
@BDisp
Fixes gui-cs#2985. Application.RunState must be responsible for dispo…
0491903 
…se the Toplevel property.
@BDisp BDisp mentioned this issue Nov 13, 2023
Merged
8 tasks
@tig tig added bug v1 For Issues & PRs targetting v1.x labels Nov 15, 2023
@tig tig closed this as completed in c7942ae Nov 15, 2023
tig added a commit that referenced this issue Nov 16, 2023
@BDisp @tig
Fixes #2985. Application.RunState must be responsible for dispose the…
720ba93 
… Toplevel property. (#2986)

Co-authored-by: Tig <tig@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug v1 For Issues & PRs targetting v1.x
Projects
None yet
Milestone
No milestone
2 participants
@tig @BDisp