TextFormatter.Lines should return a single string.Empty list even with Width or Height equal to zero.

[BDisp]

I'll fix this in the #3181 because I already have a branch of it on another wip branch.

[BDisp]

Due this fix if a View initialize with AutoSize as false setting the Height doesn't ensures that a view is drawn unless the Dim properties or the Frame are defined. Is the case of the Generic scenario where it's initializing a Button with AutoSize = false and without define a dimension. Thus doesn't make any sense to define Height = 1 in the constructor because if the Width = 0 nothing is drawn anyway.
I'll will fix this in the #3181.

[tig]

I'll fix this in the #3181 because I already have a branch of it on another wip branch.

Please don't.

I already have enough merge issues there AND I did a ton of TF fixes in #3202, which I am going to pull out into a separate PR.

[BDisp]

I want to use these changes in the #2489. It's almost ready. I'm only struggle when I use the Pos.Center on the view location and it's drawing outside the view padding.

[tig]

I want to use these changes in the #2489. It's almost ready. I'm only struggle when I use the Pos.Center on the view location and it's drawing outside the view padding.

You'll have to wait until I'm done merging #3181 and #3202. Sorry.

If you want, you can try to take the TextFormatter.cs from #3202 and create a new branch that uses it. However, this requires touching a ton of files because I changed TextFormatter significantly in #3202 (which I shouldn't have done, but I did). In particular I changed Lines to be GetLines () because it being a property getter was causing chaos in the debugger.

If you do this, DO NOT apply any code reformatting.

[BDisp]

@tig this test is failing:

	[Fact]
	[SetupFakeDriver]
	public void Button_AutoSize_False_Does_Not_Draw ()
	{
		var btn = new Button {
			AutoSize = false,
			X = Pos.Center (),
			Y = Pos.Center (),
			Text = "Press me!"
		};
		Assert.Equal ("Press me!", btn.Text);
		btn.BeginInit ();
		btn.EndInit ();
		btn.Draw ();

		Assert.Equal ($"{CM.Glyphs.LeftBracket} {btn.Text} {CM.Glyphs.RightBracket}", btn.TextFormatter.Text);
		Assert.Equal ("{Width=0, Height=1}", btn.TextFormatter.Size.ToString ());
		TestHelpers.AssertDriverContentsWithFrameAre ("", _output);
	}

The output is:

Expected:

 But Was:
          ⟦ Pr

This should be really empty because the dimension wasn't already set and IsInitialized is false. It has a width of 4 because the SetRelativeLayout, called by the constructor, is setting the Pos/Dim absolute values even without initialize the view. Do you really want to maintain the current behavior?

[tig]

@tig this test is failing:

	[Fact]
	[SetupFakeDriver]
	public void Button_AutoSize_False_Does_Not_Draw ()
	{
		var btn = new Button {
			AutoSize = false,
			X = Pos.Center (),
			Y = Pos.Center (),
			Text = "Press me!"
		};
		Assert.Equal ("Press me!", btn.Text);
		btn.BeginInit ();
		btn.EndInit ();
		btn.Draw ();

		Assert.Equal ($"{CM.Glyphs.LeftBracket} {btn.Text} {CM.Glyphs.RightBracket}", btn.TextFormatter.Text);
		Assert.Equal ("{Width=0, Height=1}", btn.TextFormatter.Size.ToString ());
		TestHelpers.AssertDriverContentsWithFrameAre ("", _output);
	}

The output is:

Expected:

 But Was:
          ⟦ Pr

This should be really empty because the dimension wasn't already set and IsInitialized is false. It has a width of 4 because the SetRelativeLayout, called by the constructor, is setting the Pos/Dim absolute values even without initialize the view. Do you really want to maintain the current behavior?

First, you need to ask "What, really, is the purpose of this test? What precisely is it testing at a unit level? I deleted this test because I moved what it was testing to where those tests belonged (Layout and Text).

There is a bug here though. Let's decode it.

SetRelativeLayout is called because the constructor (actually the View constructor) sets Text, and the Text setter ends up calling SetRelativeLayout:

SetRelativeLayout gets called again when Button sets TextAlignment in its constructor:

And again when Height is set:

And AGAIN when AutoSize is set:

etc...

Finally, when `Text = "Press me!" happens:

Before BeginInit is called:

As you note this is clearly wrong, giving AutoSize == false.

The question is, what is right (for Button)?

1. 0, 0
2. 0, 1
3. 4, 1 (current behavior)
4. 13, 1 (4 + "Press me!")

I want to view this through the lens of Dim.Auto existing (and View.AutoSize being nuked). I think, by default, Button would be set like this:

Width = Dim.Auto ();
Height = 1;

If someone were to set Width to some other value, the button would be that Width.

All that said, I think the TEST is buggy: Setting AutoSize = false invalidates Height and Width. The test never sets Height and Width and thus they are indeterminate.

This is correct:

[Fact]
[SetupFakeDriver]
public void Button_AutoSize_False_Does_Not_Draw ()
{
    var btn = new Button
    {
        AutoSize = false,
        X = Pos.Center (),
        Y = Pos.Center (),
        Height = 1,
        Width = 0,
        Text = "Press me!"
    };
    Assert.Equal ("Press me!", btn.Text);
    btn.BeginInit ();
    btn.EndInit ();
    btn.Draw ();

    Assert.Equal ($"{CM.Glyphs.LeftBracket} {btn.Text} {CM.Glyphs.RightBracket}", btn.TextFormatter.Text);
    Assert.Equal ("{Width=0, Height=1}", btn.TextFormatter.Size.ToString ());
    TestHelpers.AssertDriverContentsWithFrameAre ("", _output);
}

[BDisp]

Closing this because the Button is a special view that overrides the UpdateTextFormatterText method and thus set a minimal sie of 4 for the brackets and spaces if no width is set at object initializer. Setting only the width equal to zero, as the Button already sets the height on the constructor, the test pass. Thanks @tig.