Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application.InternalInit no longer resets ConfigurationManager - Unit tests need updating #3359

Closed
2 tasks
tig opened this issue Mar 29, 2024 · 0 comments
Closed
2 tasks
Labels
bug testing Issues related to testing

Comments

@tig
Copy link
Collaborator

tig commented Mar 29, 2024

In #3339 I changed InternalInit to not reset CM.

This enables Application to retain previous theme settings... This enables changing theme settings in UI Catalog to be reflected into a Scenario when run.

However, it means that any Unit Test that changes a setting in CM must call Reset on exit. If not, it will lead to spurious unit test failures where tests depend on default configuration.

The fixes are:

  • Add a call to CM.Reset in the AutoInitshutdown After handler.
  • Update CM Unit tests to call Reset.
@tig tig added bug testing Issues related to testing labels Mar 29, 2024
tig added a commit that referenced this issue Mar 31, 2024
Fixes #3359.  Updates Unit Tests to do CM.Reset
@tig tig closed this as completed Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug testing Issues related to testing
Projects
No open projects
Status: ✅ Done
Development

No branches or pull requests

1 participant