Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

.NET 8 support for v1.xxx #3484

Closed
cjlotz opened this issue May 17, 2024 · 3 comments · Fixed by #3486
Closed

.NET 8 support for v1.xxx #3484

cjlotz opened this issue May 17, 2024 · 3 comments · Fixed by #3486
Labels
bug build-and-deploy Issues regarding to building and deploying Terminal.Gui v1 For Issues & PRs targetting v1.x
Milestone
V1.17

Comments

@cjlotz
Copy link

cjlotz commented May 17, 2024 •
edited
Loading

Any possibility of publishing a package for v1.xxx that adds support for .NET 8.0?
@tig
Copy link
Collaborator

tig commented May 17, 2024

Any possibility of publishing a package for v1.xxx that adds support for .NET 8.0?

What's not working?

@tig tig added bug v1 For Issues & PRs targetting v1.x labels May 17, 2024
@cjlotz
Copy link
Author

cjlotz commented May 20, 2024 •
edited
Loading

I wasn't able to compile the latest v1.16.0 packages when targeting .NET 8. If this should be possible, I suspect this might be PC related as some recent updates might have broken my .NET installation.

@cjlotz cjlotz closed this as completed May 20, 2024
@tig tig mentioned this issue May 20, 2024
Merged
13 tasks
@tig tig reopened this May 20, 2024
@tig
Copy link
Collaborator

tig commented May 20, 2024

You were correct; we were only setup to compile with net7.

The library, via nuget, should work fine in a net8 project. But you are right the solution would not compile using the net8 SDK.

... fixes this.

@tig tig added the build-and-deploy Issues regarding to building and deploying Terminal.Gui label May 21, 2024
@tig tig added this to the V1.17 milestone May 25, 2024
@tig tig closed this as completed in #3486 May 29, 2024
tig added a commit that referenced this issue May 29, 2024
@tig
Merge pull request #3486 from tig/v1_3484-dotnet8
0db120d 
Fixes #3484 (V1) - Updates SDK version to dotnet8, adds `netstandard2.0` and `net8.0` `TargetFrameworks`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug build-and-deploy Issues regarding to building and deploying Terminal.Gui v1 For Issues & PRs targetting v1.x
Projects
None yet
Milestone
V1.17
2 participants
@tig @cjlotz