Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make demo.cs a simple, pretty, demo - move 'tests' to UI Catalog or UnitTests #433

Closed
tig opened this issue May 17, 2020 · 2 comments · Fixed by #2084
Closed

Make demo.cs a simple, pretty, demo - move 'tests' to UI Catalog or UnitTests #433

tig opened this issue May 17, 2020 · 2 comments · Fixed by #2084
Assignees

Comments

@tig
Copy link
Collaborator

tig commented May 17, 2020

Now that we have UI Catalog that allows quickly adding test scenarios that don't step on other tests, please move any tests out of the Example project (demo.cs) and add them to UI Catalog.

We should clean up demo.cs so it actually looks like a little app we'd be proud of. Right now it is full of cruft that either doesn't work, or is just haphazardly placed.

I've already moved Text Alignment and Mouse and will remove them from demo.cs as soon as the UI Catalog PR (#387) is accepted.

@tig tig self-assigned this May 19, 2020
@tig tig added the 1.0 label Jun 4, 2020
@tig tig added this to the v1.0 milestone Sep 28, 2020
@tig tig removed the 1.0 label Dec 27, 2020
@tig tig removed this from the v1.0 milestone Apr 28, 2021
@BDisp
Copy link
Collaborator

BDisp commented Feb 25, 2022

I think we should maintain this project to have an alternative execution test. Because of this project I found a bug (#1613) that is not reproducible on the UICatalog.

@tig
Copy link
Collaborator Author

tig commented Oct 14, 2022

In a recent Reddit post on Terminal.Gui, a commenter complained that the "Terminal.Gui samples are horrible".

I asked him to explain what he meant and he said he looked at Example and that was the basis of his assertions.

I am going to submit a PR to address this issue that will

  • Delete ./Example/demo.cs
  • Add ./Example/Example.cs - using the contents of the simple c# example that is in ./README.md
  • Update ./Example/README.md to note that the sample is intended to be a very simple example of using Terminal.Gui in C#. And to note that demo.cs has been deleted, but if people really still want it, it is in git history.

@BDisp, if you believe we should have an "alternative execution test" based on demo.cs please submit a PR that adds it, but ensure it's named in such a way that makes it obvious it is NOT an example, but a test app. Thanks.

@tig tig changed the title Make demo.cs a simple, pretty, demo - move 'tests' to UI Catalog Make demo.cs a simple, pretty, demo - move 'tests' to UI Catalog or UnitTests Oct 14, 2022
@tig tig closed this as completed in #2084 Oct 14, 2022
tig added a commit that referenced this issue Oct 14, 2022
Fixes #433 - Replaces demo.cs with standalone Example.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants