Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProgressBar: Enhancement ideas #546

Closed
tig opened this issue May 25, 2020 · 12 comments
Closed

ProgressBar: Enhancement ideas #546

tig opened this issue May 25, 2020 · 12 comments

Comments

@tig
Copy link
Collaborator

tig commented May 25, 2020

@ichan-akira
Copy link

Support a SegmentCharacter property that would allow caller to specify the character drawn for each segment (currently hard coded to Driver.Stipple).

Would be very great so we can actually draw opaque progress bar then.

@BDisp
Copy link
Collaborator

BDisp commented Jul 17, 2021

Guys, what do you think about this innovation?

progressbar

@ichan-akira
Copy link

The continuous and opaque one is the one that I actually needed that will be excellent!

@hindermath
Copy link

All styles are good and I like them all!

@BDisp
Copy link
Collaborator

BDisp commented Jul 18, 2021

I intend to added options to print fraction text and framed before submit a PR.

@BDisp
Copy link
Collaborator

BDisp commented Jul 18, 2021

* Support a `Text` property that would be centered. Clients could do  `pc.Text = "${pc.Fraction:F0}%"`

I don't agree with this be a Text property because the ProgressBar already have the fraction value and must be him to handle this and print automatically, case for e.g. a FractionText enum property (None, Inside, Outside) is set to Inside or Outside. What yours opinions about this?
I have no intention to add FractionText on the Marquee styles, because we cannot indicate the quantity of progress.

Edit:
I thought better and I only will redraw the percentage outside, because inside will hide the progress bar since the height is equal to one.

* It should render more detail depending on the height. 1 line, current design; 2 progress plus percentage; 3 framed; 4 frame with progress;

I will guide from this and what do you think about the enum name be ProgressBarFormat?

I ended up to use the Text property using the Fraction property information and forcing the setter to be always the Fraction string value. Sorry to had doubted about this.

Edit
Allows set the Text only on Marquee style.

@BDisp
Copy link
Collaborator

BDisp commented Jul 18, 2021

* Support a `SegmentCharacter` property that would allow caller to specify the character drawn for each segment (currently hard coded to `Driver.Stipple`).

I added support to this but I do not guarantee that will work with all the SegmentCharacter choosed.

@BDisp
Copy link
Collaborator

BDisp commented Jul 18, 2021

* 6 frame wothnprogress padded

I didn't understand this part. Can someone explains, please?

Edit

I already understood this.

@ichan-akira
Copy link

* 6 frame wothnprogress padded

I didn't understand this part. Can someone explains, please?

Originally from @migueldeicaza at #52

@BDisp
Copy link
Collaborator

BDisp commented Jul 18, 2021

Originally from @migueldeicaza at #52

Yes I know that, thanks. But is the same thing. I'll ignore this part.

BDisp added a commit to BDisp/Terminal.Gui that referenced this issue Jul 18, 2021
@BDisp
Copy link
Collaborator

BDisp commented Jul 18, 2021

Done folks. #546

@tig tig closed this as completed in e2d53d2 Jul 21, 2021
@migueldeicaza
Copy link
Collaborator

Glorious!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants