Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows ListView trigger the Enter and Leave events. #1508

Merged
merged 2 commits into from Nov 13, 2021

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Nov 10, 2021

Fixes #1507.

@BDisp
Copy link
Collaborator Author

BDisp commented Nov 11, 2021

With the Enter and Leave events unit test, I detected some bugs which I already fixed.
@tznind and @jmperricone if you don't agree with the changes to make successfully the unit test, please let me know to remove them. Thanks.

@tznind
Copy link
Collaborator

tznind commented Nov 12, 2021

With the Enter and Leave events unit test, I detected some bugs which I already fixed. @tznind and @jmperricone if you don't agree with the changes to make successfully the unit test, please let me know to remove them. Thanks.

Looks good to me! More unit tests are always good :) and the boundary check (Math.Max) is nice addition for TabView.

Copy link
Collaborator

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! nice.

@tig tig merged commit d84ab39 into gui-cs:main Nov 13, 2021
@BDisp BDisp deleted the listview-enter-leave-fix branch November 13, 2021 15:54
BDisp added a commit to BDisp/Terminal.Gui that referenced this pull request Nov 13, 2021
* Allows ListView trigger the Enter and Leave events.

* Added unit test for Enter and Leave events to all views.
@tig tig mentioned this pull request Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Leave event doesn't execute on ListView
3 participants