Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2267. Toplevel.EnsureVisibleBounds throws an exception if border is null. #2268

Merged
merged 1 commit into from Jan 13, 2023

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Jan 3, 2023

Fixes #2267 - The check was only done on the if condition and not in the set.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp
Copy link
Collaborator Author

BDisp commented Jan 12, 2023

@tig I updated the #2267 (comment) to show a visible issue that this PR will fix. Can you merge this to avoid making a cherry.pick on every branches where I'm working on, please. Thanks.

@tig tig merged commit 264f0b0 into gui-cs:develop Jan 13, 2023
@BDisp BDisp deleted the ensurevisiblebounds-fix-2267 branch January 13, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Toplevel.EnsureVisibleBounds throws an exception if border is null.
2 participants