Fixes #2269. ListView.EnsureSelectedItemVisible must be public. #2270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
Is it worth naming this 'EnsureSelectedItemVisible' to be consistent with
other views?
TreeView has EnsureVisible
TableView has EnsureSelectedCellIsVisible
…On Tue, 3 Jan 2023, 14:02 BDisp, ***@***.***> wrote:
Fixes #2269 <#2269> - Also
added unit tests and fix StartsWith warning.
Pull Request checklist:
- I've named my PR in the form of "Fixes #issue. Terse description."
- My code follows the style guidelines of Terminal.Gui
<https://github.com/gui-cs/Terminal.Gui/blob/develop/.editorconfig> -
if you use Visual Studio, hit CTRL-K-D to automatically reformat your
files before committing.
- My code follows the Terminal.Gui library design guidelines
<https://github.com/gui-cs/Terminal.Gui/blob/develop/CONTRIBUTING.md>
- I ran dotnet test before commit
- I have made corresponding changes to the API documentation (using ///
style comments)
- My changes generate no new warnings
- I have checked my code and corrected any poor grammar or misspellings
- I conducted basic QA to assure all features are working
------------------------------
You can view, comment on, or merge this pull request online at:
#2270
Commit Summary
- b44df1c
<b44df1c>
Fixes #2269. ListView.EnsuresVisibilitySelectedItem must be public.
File Changes
(2 files <https://github.com/gui-cs/Terminal.Gui/pull/2270/files>)
- *M* Terminal.Gui/Views/ListView.cs
<https://github.com/gui-cs/Terminal.Gui/pull/2270/files#diff-f7e7cfdef83e80b88b150ed4239c1d684ae109ea833b995091d1bd85bc5dd810>
(9)
- *M* UnitTests/ListViewTests.cs
<https://github.com/gui-cs/Terminal.Gui/pull/2270/files#diff-574af2cc959f3f31d4f795b6618261d433d0c47634ce978537b1db365616d207>
(62)
Patch Links:
- https://github.com/gui-cs/Terminal.Gui/pull/2270.patch
- https://github.com/gui-cs/Terminal.Gui/pull/2270.diff
—
Reply to this email directly, view it on GitHub
<#2270>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHO3C5CEPAPLGTG4ZUKTL7LWQQWP7ANCNFSM6AAAAAATPXBNHE>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Done. Thanks @tznind. |
tig
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2269 - Also added unit tests and fix
StartsWithwarning.Pull Request checklist:
CTRL-K-Dto automatically reformat your files before committing.dotnet testbefore commit///style comments)