Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2293. WindowsDriver forces minimum console height equal to 1, but should allow be 0. #2294

Merged
merged 2 commits into from
Jan 18, 2023
Merged

Fixes #2293. WindowsDriver forces minimum console height equal to 1, but should allow be 0. #2294

merged 2 commits into from
Jan 18, 2023

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Jan 17, 2023 •
edited
Loading

Fixes #2293 - Only the 'OutputHandle' can be set a height to 0 and the ScreenBuffer must have a minimum height of 1, in the case where we don't want use buffer.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

windows-driver-height-0-fix

@BDisp BDisp mentioned this pull request Jan 18, 2023
Open
tig
tig approved these changes Jan 18, 2023
View reviewed changes
Copy link
Collaborator

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch & fix!

@tig tig merged commit 2e7c2c8 into gui-cs:develop Jan 18, 2023
@BDisp BDisp deleted the windowsdriver-height-fix_2293 branch January 18, 2023 16:01
@BDisp BDisp mentioned this pull request Feb 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tig tig tig approved these changes

@migueldeicaza migueldeicaza Awaiting requested review from migueldeicaza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WindowsDriver forces minimum console height equal to 1, but should allow be 0.
2 participants
@BDisp @tig