Illustrates #2331 (Scrollview not respecting clip) does not reproduce #2332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tig
changed the title
…Button shows outside
|
There is still a bug on this issue and this PR fixes it. If you run the |
tig
added a commit
to tig/Terminal.Gui
that referenced
this pull request
Feb 20, 2023
… not reproduce (gui-cs#2332)" This reverts commit c85ff95.
tig
added a commit
that referenced
this pull request
Feb 21, 2023
#2372) * Illustrates #2331 (Scrollview not respecting clip) does not reproduce (#2332) * Proves that the issue #2331 don't have reason to happen. * fixes #2336 * Fixes #2331. ScrollView may not be honoring clip region; CustomButton shows outside * More appropriate solution for the issue #2331. * Start refactoring LineCanvas for mixing line style support (e.g. double into single) * Add remaining resolvers * Implement corner border style mixing in LineCanvas * Refactor and simplify resolvers * Move tests to Core folder and namespace to Terminal.Gui.CoreTests * Fixes #2333. TextField is selecting badly a word on double click. * Add unit test deleting a word with accented char. * Fixes 2331. ScrollView may not be honoring clip region. * Add a custom button scenario. * Fixes #2350. Clipping broke (see Clipping scenario). * Is preferable use NeedDisplay instead of Bounds. --------- Co-authored-by: Tig Kindel <tig@users.noreply.github.com> Co-authored-by: tznind <tznind@dundee.ac.uk> * Fixes ASCIICustomButton scenario. * Adds Snake Scenario (#2353) * Add empty snake scenario * Move snake head around * Snake now has a tail * Rest of logic implementation * Ctrl K D layout fixes * Game gets faster as you collect more apples * Adjust speed increase rate down * Use white on black for snake and border and red for apple * Fix ScenarioTests not Disposing Scenario * Add disposes and fix to use LineCanvas.GenerateImage * Fix stack overflow, doh! --------- Co-authored-by: Tig <tig@users.noreply.github.com> * Fixes 2368. Nested views with height of 1 not rendering correctly. --------- Co-authored-by: Tig Kindel <tig@users.noreply.github.com> Co-authored-by: tznind <tznind@dundee.ac.uk> Co-authored-by: Thomas Nind <31306100+tznind@users.noreply.github.com>
BDisp
pushed a commit
to BDisp/Terminal.Gui
that referenced
this pull request
Feb 27, 2023
… not reproduce (gui-cs#2332)" This reverts commit c85ff95.
BDisp
added a commit
to BDisp/Terminal.Gui
that referenced
this pull request
Feb 27, 2023
…) does not reproduce (gui-cs#2332)" committed twice on 6bb90ed and 28d7be7
BDisp
added a commit
to BDisp/Terminal.Gui
that referenced
this pull request
Mar 1, 2023
…) does not reproduce (gui-cs#2332)" committed twice on 6bb90ed and 28d7be7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit test for #2331 - I think there is some issue on how the user is drawing the CustomButton. As you can see in the unit test none of the CustomButton over-spill the
ScrollView.Pull Request checklist:
CTRL-K-Dto automatically reformat your files before committing.dotnet testbefore commit///style comments)