Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LineCanvas support for mixing double and single lines #2339

Merged
merged 6 commits into from Feb 12, 2023

Conversation

tznind
Copy link
Collaborator

@tznind tznind commented Feb 10, 2023

Fixes #_____ - Include a terse summary of the change or which issue is fixed.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@tznind tznind changed the title WIP: Start refactoring LineCanvas for mixing line style support LineCanvas support for mixing double and single lines Feb 11, 2023
@tznind tznind marked this pull request as ready for review February 11, 2023 00:05
@tznind
Copy link
Collaborator Author

tznind commented Feb 11, 2023

Mixed line style support, have doubles merge into singles and vice versa!

On my laptop on holiday so can't do the Ctrl+K+D thing but otherwise should be good to go.

Copy link
Collaborator

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments. It's not working for all orientations.

UnitTests/LineCanvasTests.cs Show resolved Hide resolved
@tig
Copy link
Collaborator

tig commented Feb 11, 2023

Also, @tznind, can you please move LineCanvasTests.cs to the Core folder and ensure the namespace is Terminal.Gui.Core?

@tznind
Copy link
Collaborator Author

tznind commented Feb 11, 2023

Also, @tznind, can you please move LineCanvasTests.cs to the Core folder and ensure the namespace is Terminal.Gui.Core?

Done. Guessing you mean Terminal.Gui.CoreTests though right? Not justTerminal.Gui.Core?

@tig
Copy link
Collaborator

tig commented Feb 12, 2023

I just grabbed your PR again using a different technique and now it's correct and working correctly.

git remote add tznind tig:tznind/gui.cs.git
git fetch tznind
git checkout -b tznind-line-canvas-style-mixing tznind/line-canvas-style-mixing  

😕

Copy link
Collaborator

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@tig tig merged commit 2ead01a into gui-cs:develop Feb 12, 2023
@tznind
Copy link
Collaborator Author

tznind commented Feb 13, 2023

@tig just recording this here as I don't think theres much we can do about it but the current implementation still looks a bit janky when changing from double to single 'mid rune' along a specific axis. For example if you draw 2 boxes, one with single width and one with double width overlapping:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants