New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LineCanvas support for mixing double and single lines #2339
Conversation
Mixed line style support, have doubles merge into singles and vice versa! On my laptop on holiday so can't do the Ctrl+K+D thing but otherwise should be good to go. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comments. It's not working for all orientations.
Also, @tznind, can you please move |
Done. Guessing you mean |
I just grabbed your PR again using a different technique and now it's correct and working correctly.
😕 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<3
@tig just recording this here as I don't think theres much we can do about it but the current implementation still looks a bit janky when changing from double to single 'mid rune' along a specific axis. For example if you draw 2 boxes, one with single width and one with double width overlapping: |
Fixes #_____ - Include a terse summary of the change or which issue is fixed.
Pull Request checklist:
CTRL-K-D
to automatically reformat your files before committing.dotnet test
before commit///
style comments)