Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2758. ReSharper unit tests detects errors that VS2022 don't. #2759

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Jul 19, 2023

Fixes #2758 - Set CultureInfo.DefaultThreadCurrentUICulture = CultureInfo.GetCultureInfo ("en-US") in the AutoInitShutdownAttribute was enough. Also fixed some typos.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

imagem

@BDisp
Copy link
Collaborator Author

BDisp commented Jul 19, 2023

But still happens this #2758 (comment) because the threads are not properly disposed.

imagem

@tig tig merged commit d02a5b6 into gui-cs:develop Jul 19, 2023
1 check passed
@BDisp BDisp deleted the v1_current-culture-fix_2758 branch July 19, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReSharper unit tests detects errors that VS2022 don't.
2 participants