Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2761. Small TextView is broken scrolling using scrollbar. #2770

Merged
merged 9 commits into from
Aug 11, 2023

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Jul 25, 2023

Fixes #2761 - The principal culprit is the SetRelativeLayout being called with the wrong Frame value. For e.g. a TextView inside a FrameView but using the Window's ContentView.Frame instead of FrameView.Frame.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@tig tig changed the title Fixes #2761. Small TextView's broken scrolling using scrollbar. Fixes #2761. Small TextView is broken scrolling using scrollbar. Jul 26, 2023
@BDisp BDisp marked this pull request as draft July 26, 2023 13:04
@BDisp
Copy link
Collaborator Author

BDisp commented Jul 26, 2023

@tig I'll add more unit tests to guarantee that this doesn't happens anymore.

@BDisp BDisp marked this pull request as ready for review July 26, 2023 22:19
@BDisp
Copy link
Collaborator Author

BDisp commented Jul 26, 2023

I think it's all done @tig.
@chr1st0scli I added the follow on the unit tests to the TextViewScrollBarView because BottonOffset isn't be set as it was sets before subscribing the event and thus ensure get his state on driver initialization.

				Initialized += TextViewScrollBarView_Initialized;
				OtherScrollBarView.Initialized += OtherScrollBarView_Initialized;

@tig tig merged commit b40d2a6 into gui-cs:develop Aug 11, 2023
1 check passed
@tig
Copy link
Collaborator

tig commented Aug 11, 2023

@BDisp can you bring this fix forward into v2_develop too? Thanks.

@BDisp BDisp deleted the v1_textview-scrolling-fix_2761 branch August 11, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Small TextView is broken scrolling using scrollbar
2 participants