-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #2761. Small TextView is broken scrolling using scrollbar. #2770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tig
changed the title
Fixes #2761. Small TextView's broken scrolling using scrollbar.
Fixes #2761. Small TextView is broken scrolling using scrollbar.
Jul 26, 2023
tig
approved these changes
Jul 26, 2023
@tig I'll add more unit tests to guarantee that this doesn't happens anymore. |
I think it's all done @tig. Initialized += TextViewScrollBarView_Initialized;
OtherScrollBarView.Initialized += OtherScrollBarView_Initialized; |
tig
approved these changes
Aug 11, 2023
@BDisp can you bring this fix forward into v2_develop too? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2761 - The principal culprit is the
SetRelativeLayout
being called with the wrongFrame
value. For e.g. aTextView
inside aFrameView
but using theWindow
'sContentView.Frame
instead ofFrameView.Frame
.Pull Request checklist:
CTRL-K-D
to automatically reformat your files before committing.dotnet test
before commit///
style comments)