Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2767. Remove EnableConsoleScrolling - BREAKING CHANGE #2773

Merged

Conversation

tig
Copy link
Collaborator

@tig tig commented Jul 26, 2023

Fixes #2767

Because the API is not removed, this is not an API breaking change. But I'm labeling it anyway because users should be aware this functionality no longer works.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@tig tig requested a review from migueldeicaza as a code owner July 26, 2023 14:11
@tig tig changed the title Fixes #2767. Remove EnableConsoleScrolling Fixes #2767. Remove EnableConsoleScrolling - BREAKING CHANGE Jul 26, 2023
@tig tig added the breaking-change For PRs that introduces a breaking change (behavior or API) label Jul 26, 2023
@tig tig requested review from BDisp and removed request for migueldeicaza July 26, 2023 14:16
@tig tig requested a review from BDisp July 26, 2023 14:59
@tig tig merged commit 993e484 into gui-cs:develop Jul 26, 2023
1 check passed
@tig tig deleted the v1_fixes_2767_deprecate_enableconsolescrolling branch April 3, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change For PRs that introduces a breaking change (behavior or API)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EnableConsoleScrolling should be deprecated
2 participants