Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2775. Something in 1.13 broke centering child windows. #2778

Merged
merged 57 commits into from
Oct 17, 2023
Merged

Fixes #2775. Something in 1.13 broke centering child windows. #2778

merged 57 commits into from
Oct 17, 2023

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Jul 29, 2023

Fixes #2775 - Application.Begin always call LayoutSubviews but when a view is added after the app is running all the views that overridden Redraw's method must call it explicitly.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner July 29, 2023 22:21
@dodexahedron dodexahedron mentioned this pull request Jul 31, 2023
Closed
BDisp and others added 10 commits July 31, 2023 23:21
@BDisp
Copy link
Collaborator Author

BDisp commented Aug 6, 2023

windowchildonparent.mp4

@BDisp BDisp marked this pull request as draft August 7, 2023 13:47
@BDisp BDisp mentioned this pull request Aug 20, 2023
Merged
@BDisp BDisp mentioned this pull request Aug 24, 2023
Closed
@BDisp BDisp mentioned this pull request Aug 29, 2023
Closed
@BDisp
Fix an issue where NullReferenceException can be throws everywhere wh…
c8f2d06 
…ile get the Application.MdiChildes property.
tig
tig approved these changes Aug 30, 2023
View reviewed changes
Terminal.Gui/Views/Menu.cs Outdated Show resolved Hide resolved
@tig
Copy link
Collaborator

tig commented Aug 30, 2023

@BDisp please resolve merge conflicts.

@BDisp
Copy link
Collaborator Author

BDisp commented Aug 30, 2023

I resolved the conflicts but I can't run it neither the develop branch. See #2815 (comment).

@BDisp
Copy link
Collaborator Author

BDisp commented Aug 30, 2023

I resolved the conflicts but I can't run it neither the develop branch. See #2815 (comment).

Done. Now it's working.

@BDisp BDisp mentioned this pull request Sep 8, 2023
Closed
@tig tig merged commit 3e1637a into gui-cs:develop Oct 17, 2023
1 check passed
@BDisp BDisp deleted the v1_centering-child-window-fix_2775 branch October 17, 2023 18:09
@dodexahedron
Copy link
Collaborator

Nice change set. Fixed a couple of things I thought were my fault in another application.

And of course I'm certainly happy about the fix for #2775 being part of this PR 😅

Thanks for your efforts. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tig tig tig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Something in 1.13 broke centering child windows
3 participants
@BDisp @tig @dodexahedron