Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #2824. Add SearchText property to ComboBox #2825

Merged
merged 6 commits into from
Sep 29, 2023

Conversation

MaciekWin3
Copy link
Contributor

Fixes #2824 - Added SearchText property to ComboBox

Also, the issue of resetting the text in the search field was resolved. For instance, when utilizing a constructor to provide text that I presumed should serve as the default content in the search field, the text was getting reset upon adding the ComboBox to the Window. Moreover, this text was also reset when a button was pressed and no item was selected from the ComboBox. This behavior was quite annoying.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@MaciekWin3 MaciekWin3 requested a review from tig as a code owner August 19, 2023 11:38
@MaciekWin3 MaciekWin3 changed the title Fixes #2824 - Add SearchText property to ComboBox Fixes #2824. Add SearchText property to ComboBox Aug 24, 2023
Copy link
Collaborator

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create another PR that applies this fix to v2 as well. Thanks.

@tig tig merged commit 2b47162 into gui-cs:develop Sep 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SearchText property to ComboBox
2 participants