Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3090. Introduce StatusItem.HotTextSpecifier #3093

Merged
merged 3 commits into from Jan 4, 2024

Conversation

AndreyAkinshin
Copy link
Contributor

Fixes #3090 - Include a terse summary of the change or which issue is fixed.

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

Copy link
Collaborator

@tig tig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done.

So we're clear, I'm breaking the rule of "no new v1 APIs" by supporting this. I'm doing so for several reasons: I love drawing in new contributors who are willing to do the work to submit PRs. And StatusBar is super-legacy and will die a slow death in the v2 world, so who really cares ;-).

But this does need new unit tests before I'll approve it.

@AndreyAkinshin
Copy link
Contributor Author

So we're clear, I'm breaking the rule of "no new v1 APIs" by supporting this.

Thank you, much appreciate it!

But this does need new unit tests before I'll approve it.

A unit test is added.

@tig tig merged commit b4975f4 into gui-cs:develop Jan 4, 2024
4 checks passed
@AndreyAkinshin AndreyAkinshin deleted the v1_status_item_tilde branch January 4, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: customization of the color changing symbol in StatusItem
2 participants