Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #3317. v1-Listvew mouse event doesn't cause a SelectedItemChanged event to fire #3321

Merged
merged 3 commits into from Mar 16, 2024
Merged

Fixes #3317. v1-Listvew mouse event doesn't cause a SelectedItemChanged event to fire #3321

merged 3 commits into from Mar 16, 2024

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Mar 13, 2024

Fixes

Proposed Changes/Todos

  • Also fire event if AllowsMarking is true on click
  • Added unit test for proof

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner March 13, 2024 21:23
dodexahedron
dodexahedron suggested changes Mar 14, 2024
View reviewed changes
Copy link
Collaborator

@dodexahedron dodexahedron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor nitpick on terminology

UnitTests/Views/ListViewTests.cs Outdated Show resolved Hide resolved
@tig tig changed the title Fixes #3317. Listvew mouse event doesn't cause a SelectedItemChanged event to fire Fixes #3317. v1-Listvew mouse event doesn't cause a SelectedItemChanged event to fire Mar 14, 2024
@tig tig merged commit 214ff12 into gui-cs:develop Mar 16, 2024
4 checks passed
@BDisp BDisp deleted the v1_listview-selecteditemchanged-marks-click.fix_3317 branch March 16, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dodexahedron dodexahedron dodexahedron requested changes

@tig tig tig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Listvew mouse event doesn't cause a selecteditemchange event to fire
3 participants
@BDisp @tig @dodexahedron