-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #3418. TextFormatter bugs. #3429
Conversation
Horizontal: Vertical: Horizontal Justified: Vertical Justified: Horizontal without wrap: Vertical without wrap: Horizontal with wrap: Vertical with wrap: Horizontal Justified with wrap: Vertical Justified with wrap: Horizontal with wrap and 2 lines: Vertical with wrap and 2 lines: The horizontal and vertical justified behavior with word wrap is considered the left and top alignments respectively, for obvious reason, of course. |
@tig I fixed the issue you mentioned on the #3418 (comment). Maybe it help you with your PR. Cheers. |
I already have this working well here and I'll submit a PR to your branch #3416 after I reviewed it. |
@tig shouldn't labels respect new lines? Or am I mistaken? Notice that there is a new line between the two words. |
Yes, if Text has new lines in it, they should be respected. |
I am not going to spend any time looking at this PR. If you want to continue to use it, please mark it as draft. |
Fixes
TextFormatter
bugs #3418Proposed Changes/Todos
Pull Request checklist:
CTRL-K-D
to automatically reformat your files before committing.dotnet test
before commit///
style comments)