Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Game using Terminal.gui called "Capital and Cargo" to showcase.md #3446

Merged
merged 1 commit into from
May 1, 2024

Conversation

dhorions
Copy link
Contributor

@dhorions dhorions commented May 1, 2024

My 12 year old son and I built a game using Terminal.gui.
I believe it would be a good candidate to be on the Showcase list of this project.
If you agree, please approve this pull request, but if you don't, that is also fine.

Changes

Add https://github.com/dhorions/Capital-and-Cargo to showcase.md

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@dhorions dhorions requested a review from tig as a code owner May 1, 2024 06:54
@tig
Copy link
Collaborator

tig commented May 1, 2024

WOW!

I love this. I only played for a few minutes, but it's addicting.

Kudos to your son (and you)!

It would be killer if you could port this to v2 asap so we have another real-world test case of all the new APIs.

@dhorions
Copy link
Contributor Author

dhorions commented May 1, 2024

It would be killer if you could port this to v2 asap so we have another real-world test case of all the new APIs.

I haven't looked into the differences with v2, will it be a lot of rework you think?
Is there some kind of conversion documentation?

@tig
Copy link
Collaborator

tig commented May 1, 2024

It would be killer if you could port this to v2 asap so we have another real-world test case of all the new APIs.

I haven't looked into the differences with v2, will it be a lot of rework you think? Is there some kind of conversion documentation?

Actually, if you're interested maybe what I'll do is submit a PR to your repo and do the porting myself.

This will help me flush out the docs!

@tig tig merged commit 065633f into gui-cs:develop May 1, 2024
3 checks passed
@dodexahedron
Copy link
Collaborator

Love it!

@dhorions
Copy link
Contributor Author

dhorions commented May 2, 2024

It would be killer if you could port this to v2 asap so we have another real-world test case of all the new APIs.

I haven't looked into the differences with v2, will it be a lot of rework you think? Is there some kind of conversion documentation?

Actually, if you're interested maybe what I'll do is submit a PR to your repo and do the porting myself.

This will help me flush out the docs!

That is a great idea. What do you think @dasmehe

@dasmehe
Copy link

dasmehe commented May 2, 2024

I

It would be killer if you could port this to v2 asap so we have another real-world test case of all the new APIs.

I haven't looked into the differences with v2, will it be a lot of rework you think? Is there some kind of conversion documentation?

Actually, if you're interested maybe what I'll do is submit a PR to your repo and do the porting myself.
This will help me flush out the docs!

That is a great idea. What do you think @dasmehe

I like it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants