Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3540. V2: Keyboard input not working on Unix platforms #3542

Merged
merged 4 commits into from
Jun 17, 2024

Conversation

BDisp
Copy link
Collaborator

@BDisp BDisp commented Jun 15, 2024

Fixes

Proposed Changes/Todos

  • Fix numeric input nor working on Linux and macOS
  • Fix more other keys not working on macOS
  • Fix Buttons scenarios which throw an exception

Pull Request checklist:

  • I've named my PR in the form of "Fixes #issue. Terse description."
  • My code follows the style guidelines of Terminal.Gui - if you use Visual Studio, hit CTRL-K-D to automatically reformat your files before committing.
  • My code follows the Terminal.Gui library design guidelines
  • I ran dotnet test before commit
  • I have made corresponding changes to the API documentation (using /// style comments)
  • My changes generate no new warnings
  • I have checked my code and corrected any poor grammar or misspellings
  • I conducted basic QA to assure all features are working

@BDisp BDisp requested a review from tig as a code owner June 15, 2024 23:21
@tig tig merged commit 9e4169a into gui-cs:v2_develop Jun 17, 2024
1 check passed
@BDisp BDisp deleted the v2_3540_unix_keyboard-fix branch June 17, 2024 13:47
@tig tig mentioned this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants