Add fixture for an LLM #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 7, 2024
Closed
Add in fixture Comment on those not working with Phi2 Switch to fixture Switch to fixtures Can use pytest parameterisation... Switching to command line based fixture More switching Convert others Explanatory note
riedgar-ms
force-pushed
the
riedgar-ms/transformer-model-fixture-01
branch
from
5446660
to
85fe42f
Compare
|
When we have the GPU runner machines available, we can start expanding the |
…mer-model-fixture-01
Harsha-Nori
reviewed
Mar 14, 2024
Comment on lines
+43
to
+44
| if model_type == "PhiForCausalLM": | ||
| pytest.xfail("See https://github.com/guidance-ai/guidance/issues/681") |
There was a problem hiding this comment.
Nice use of xfail for conditional failures that come from upstream sources
|
LGTM once tests pass |
|
Also LGTM. Thanks @riedgar-ms ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
selected_modelfixture which can provide any test with a 'live' LLM (as opposed tomodels.Mock()). This fixture is controlled by adding--selected_model <name>to the invocation ofpytest. If no model is specified on the command line, then a CPU-based GPT2 model will be provided. The valid values for<name>are the keys of theAVAILABLE_MODELSdictionary.A few of the tests are XFAILED for Phi-2 only, pending this issue:
https://huggingface.co/microsoft/phi-2/discussions/116