Removed side effect on the stop argument from _gen #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can I suggest that you add a test case to avoid future regressions? |
|
Good idea. I'll submit a new request tomorrow, probably.
…On Wed, Mar 6, 2024 at 2:49 PM Richard Edgar ***@***.***> wrote:
Can I suggest that you add a test case to avoid future regressions?
—
Reply to this email directly, view it on GitHub
<#677 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAHZ6W2DIBJQH2U53A3MVDYW5XMNAVCNFSM6AAAAABEIZB45SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBRGY3DQNJXG4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
function. Calling append on `stop` can cause issues if the same list is used in multiple situations in the same parent context. Using a non-destructive method to update the stop list also makes invoking gen over rpyc possible.
|
I revised the commit to add a test. |
|
Looks great, thanks @VincentToups ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling append on
stopcan cause issues if the same list is used in multiple situations in the same parent context. Using a non-destructive method to update the stop list also makes invoking gen over rpyc possible.