Separate out server tests #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harsha-Nori
reviewed
Mar 14, 2024
Comment on lines
+15
to
+20
| [tool.black] | ||
| line-length = 88 | ||
| target_version = ['py38', 'py39', 'py310', 'py311'] | ||
|
|
||
| [tool.isort] | ||
| profile = "black" |
There was a problem hiding this comment.
Perhaps we can hold off on forcing black and isort from this PR?
There was a problem hiding this comment.
This doesn't force black. It configures black if people run it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests in
test_server.pyseem to be a touch temperamental, often failing when the forked server process fails to start in time. In an effort to reduce the re-running of tests, add aservermark for these tests, and run in a separate runner job. Use a new workflow file so that everything doesn't get killed by the first failure.