replace catches of the ImportError exception with the more specific ModuleNotFoundError exception #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oduleNotFoundError exception
|
The test failures seem unrelated to this PR as another unrelated PR seems to be failing on the same tests. |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #733 +/- ##
==========================================
- Coverage 69.17% 65.47% -3.70%
==========================================
Files 53 53
Lines 3951 3951
==========================================
- Hits 2733 2587 -146
- Misses 1218 1364 +146 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should partly address #690 where it appears the import of llama-cpp is generating an ImportError exception that is not due to the module not being installed. This more specific exception will only catch the specific case of the Module not being installed and will leave other exceptions to propagate to the user with more descriptive errors.