Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Improved JSON Schema support #787

Merged

Conversation

riedgar-ms
Copy link
Collaborator

@riedgar-ms riedgar-ms commented Apr 30, 2024

Add some extra support for JSON schema, to work better with the langchain examples:

  • Allow definitions to be given in a definitions key, as well as $defs
  • Allow for single-entry allOf blocks

@riedgar-ms
Copy link
Collaborator Author

Tag @hudson-ai for info

@Harsha-Nori
Copy link
Collaborator

@nopdive might have thoughts too

@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.49%. Comparing base (06cc3f5) to head (ca5e477).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #787      +/-   ##
==========================================
+ Coverage   55.51%   62.49%   +6.97%     
==========================================
  Files          55       55              
  Lines        4071     4082      +11     
==========================================
+ Hits         2260     2551     +291     
+ Misses       1811     1531     -280     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nopdive
Copy link
Contributor

nopdive commented Apr 30, 2024

LGTM -- this really helps on supporting a wider variety of json schemas!

@riedgar-ms riedgar-ms merged commit 92afe33 into guidance-ai:main May 1, 2024
99 checks passed
@riedgar-ms riedgar-ms deleted the riedgar-ms/json-schema-tweaks-01 branch May 1, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants