fix: add danger config in check pull request rule

guidesmiths · Jul 5, 2021 · 92f0225 · 92f0225
1 parent 4e4a529
commit 92f0225
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/rules/checkPullRequest.ts b/src/rules/checkPullRequest.ts
@@ -18,7 +18,7 @@ export const checkPullRequest = (dangerConfig: DangerConfig) => {
     { ruleResult: checkRequestedReviewers(dangerConfig), isMandatory: false },
     { ruleResult: checkTicketLinkInPrBoby(dangerConfig), isMandatory: true },
     { ruleResult: checkUpdatedTests(dangerConfig), isMandatory: false },
-    { ruleResult: checkApprovals(), isMandatory: true }
+    { ruleResult: checkApprovals(dangerConfig), isMandatory: true }
   ]
 
   const mandatoryRules:RuleItem[] = rules.filter(({ isMandatory }) => isMandatory)

diff --git a/src/test/unitFixtures/rules/checkPullRequest/input/flawlessCode.ts b/src/test/unitFixtures/rules/checkPullRequest/input/flawlessCode.ts
@@ -28,6 +28,18 @@ export const flawlessCode = {
     body: '',
     state: 'APPROVED'
   },
+  {
+    id: 2,
+    user: {
+      id: 0,
+      login: 'IrrelevantUserName2',
+      type: 'User',
+      avatar_url: 'irrelevant_url_2',
+      href: 'irrelevant_url_2'
+    },
+    body: '',
+    state: 'COMMENT'
+  },
   {
     id: 2,
     user: {