Doesn't work for sections with height "200vh"

[robpoole]

When setting up a site with sections that are 2x the viewport height the plugin doesn't work. When scrolling to the first section the plugin kicks in and scrolls all the way to the bottom on the page.

[guidobouman]

What if you use a pixel height value?

And do you have a live testing url?

[gvdm]

I have the same issue, I think it is simply to do with uneven sized sections (with minimum size being equal to scrolling container, snap scrolling is unintuitive in situations where that is not true).

This seems to happen whenever any section is larger than the scrolling container. Ideally, the plugin would hold off snapping till the end of the section has been scrolled to. Furthermore, to aid identification of the bug, the plugin will keep snapping to the last section even when you try scrolling back up through sections. This is true of panelSnap 0.14.0 despite a similar issue #64 being closed.

Please see http://jsfiddle.net/pspp9veg/1/ for an example, the first snap is fine, thereafter problematic. Have a go.

[ynaveed]

I have sorted down the problem to the function scrollStop. The childNumber exceeds the value of panelCount and therefore it scrolls to the bottom of the page. As stated above, this happens when the panels are short in height and of variable sizes. For me this particularly happens at around 700px height. I'll update when I have a solution

Update:
The actual reason turns out to be the scrollOffset being constant. As the panels have variable height (min-height: 100vh), thus they expand vertically on lower widths. The offset remains the same, thus the panel number exceeds the max-panels due to this calculation

• childNumber = Math.round(offset / self.scrollInterval);
  Thus it snaps to the last panel.

[ynaveed]

It's dirty solution, but I made to work. Instead of using the scroll offsets to judge which panel should it snap to, I used the given function getPanelsInView to get the panels. As their can be at max 2 panels in view (in my case at least), I keep a direction variable (up/down) and pass one of the panels for snapping.

[guidobouman]

That's actually quite smart @ynaveed! I'll take a look at it this this weekend.

[gvdm]

Would this also be related to the display breaking in a similar fashion when some sections are "display:none;"? Hopefully this fixes that too.

[gvdm]

@guidobouman any chance of this making it into some code I can look at and use?

@ynaveed for those of us who haven't gone into the code can you provide a branch with a commit/diff that I can view?

[theones]

@ynaveed ynaveed can you send some code of that ?

[ynaveed]

https://github.com/ynaveed/jquery-panelsnap/tree/quickFix

[guidobouman]

You seem to have forgotten to push your changes to that branch.

[ynaveed]

Oh yes, sorry for that. Please check now.

Regards,
Yasir

On Thu, May 21, 2015 at 5:54 PM, Guido Bouman notifications@github.com
wrote:

You seem to have forgotten to push your changes to that branch.

—
Reply to this email directly or view it on GitHub
#77 (comment)
.