Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix END-IF error being thrown for END-FOR #321

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

davidjb
Copy link
Contributor

@davidjb davidjb commented Jul 28, 2023

If a template an errant END-FOR command, the current behaviour is to throw an error with the text:

Unexpected END-IF outside of IF statement context: end-for person

However, the command message is describes the wrong command/structure used.

This PR changes the outputted error message to report the command name used and corresponding context, working for both END-IF/END-FOR commands.

This can be reproduced with a template like this, with just the following text and nothing else:

+++END-FOR person+++

@jjhbw
Copy link
Collaborator

jjhbw commented Jul 29, 2023

Great find, this does indeed look like a mistake! I'll test, merge, and release this on Monday.

@jjhbw jjhbw merged commit 234bc9b into guigrpa:master Jul 31, 2023
3 checks passed
@davidjb davidjb deleted the end-for-improvements branch August 14, 2023 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants