Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document $idx loop index variable in README #323

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

davidjb
Copy link
Contributor

@davidjb davidjb commented Aug 16, 2023

This adds info about the implicit $idx loop index variable into the README.

@jjhbw
Copy link
Collaborator

jjhbw commented Aug 16, 2023

Wow great find! This is AFAIK not intentional behaviour, but we may as well formalise it. The implementation is stable. I'll add some test coverage for it, too.

@jjhbw jjhbw merged commit 30bfefd into guigrpa:master Aug 16, 2023
3 checks passed
@jjhbw
Copy link
Collaborator

jjhbw commented Aug 16, 2023

@davidjb Added a test in a3c8c6d and extended the docs a bit with an example. Thanks for noticing this!

@jjhbw
Copy link
Collaborator

jjhbw commented Aug 16, 2023

@davidjb would be great if you could take a last look at a3c8c6d by the way to check if you see anything weird.

@davidjb
Copy link
Contributor Author

davidjb commented Aug 16, 2023

Lgtm @jjhbw - nice work on the tests and extra documentation 👍

@davidjb davidjb deleted the idx-readme branch August 16, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants