Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically update dependent packages when publishing #104

Closed
wants to merge 3 commits into from

Conversation

onigoetz
Copy link

Hi @guigrpa,

This PR addresses the issues mentioned in #100 opened by @jeroenptrs

What it does :

  • When a package is dirty, all packages that depend on it (recursively) get flagged as dirty as well
  • Once a version is chosen, it will update the version in all packages including the dependencies.

What this PR could do better:
This current implementation is a naive approach to open the discussion, it could be improved by

  • Only updating the version if it's not in range
  • Allow to specify to set dependencies in ranges (^) instead of exact versions

What do you think ?

@coveralls
Copy link

coveralls commented Jul 16, 2020

Coverage Status

Coverage decreased (-0.03%) to 80.28% when pulling 983ac29 on onigoetz:master into 693e599 on guigrpa:master.

@guigrpa
Copy link
Owner

guigrpa commented Jul 25, 2020

I've finally implemented it myself, using oao bump internally (it implements the same behaviour, actually). Thanks for the effort and ideas in #100 (which have been credited in the changelog).

@guigrpa guigrpa closed this Jul 25, 2020
@onigoetz
Copy link
Author

Cool, you're welcome :) I didn't need my code to be included, ideas are more important than code :)

I inspired myself from the bump command, didn't think of just importing it though ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants