Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make replaceAt faster #9

Merged
merged 1 commit into from Apr 2, 2017
Merged

Make replaceAt faster #9

merged 1 commit into from Apr 2, 2017

Conversation

gamtiq
Copy link
Contributor

@gamtiq gamtiq commented Mar 23, 2017

I have made an optimization of replaceAt and now the function works faster.
It seems sometimes old for-cycle beats array's native methods.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling f5a6804 on gamtiq:optimize-replaceAt into 748d828 on guigrpa:master.

@guigrpa
Copy link
Owner

guigrpa commented Apr 2, 2017

Thanks a lot, and sorry for the delay in reviewing this (I was on holiday). I'm merging this right away.

@guigrpa guigrpa merged commit 0f27e35 into guigrpa:master Apr 2, 2017
@guigrpa
Copy link
Owner

guigrpa commented Apr 2, 2017

Released in v1.2.5, thanks again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gamtiq @coveralls @guigrpa