feat: reduce dependencies contraints #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paw-lu Do you mind taking a look? Not much to see, I just want to confirm if that's the solution we both believe is good. I committed it as |
paw-lu
reviewed
Apr 23, 2022
motivated by this issue: #47 in short: We don't want to restrict users from using Tryceratops because some other lib bumped its major version (e.g. Rich) by reading https://iscinumpy.dev/post/bound-version-constraints/ it got clear that Tryceratops should be more permissive we're keeping dev dependencies as is since they should be installed only locally for developmemnt purposes
guilatrova
force-pushed
the
reduce-constraints
branch
from
0b24c9e
to
019fe52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by this issue: #47
in short: We don't want to restrict users from using Tryceratops
because some other lib bumped its major version (e.g. Rich)
by reading https://iscinumpy.dev/post/bound-version-constraints/
it got clear that Tryceratops should be more permissive
we're keeping dev dependencies as is since they should be installed
only locally for development purposes