Alpha dpp dev #62
Merged
Alpha dpp dev #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ddition of other intermediate samplers
… magic slicing rules)
… to use stable filter
testing negative eigenvalues of a PSD matrix but not setting them to 0
…void overwriting random_state variable
add also better checks on optimization of alpha_hat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the associated paper at NeurIPS '20 on fast exact DPP sampling without looking at all items .
This pull request provides a full implementation together with full docstrings and partial docs explaining the algorithm. We are merging it to receive early feedback from users and use it to prepare an improve docs version soon.
All APIs are unchanged, except for a new mode
"alpha"provided for both DPP and k-DPP sampling. Internally, thevfx_sampling.pyfile was replaced with a more genericintermediate_sampling.pycontaining bothvfxandalphaalgorithms.