Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure library is being deprecated #30

Closed
proycon opened this issue May 4, 2020 · 1 comment · Fixed by #69
Closed

Failure library is being deprecated #30

proycon opened this issue May 4, 2020 · 1 comment · Fixed by #69
Assignees

Comments

@proycon
Copy link
Contributor

proycon commented May 4, 2020

I happened to come across the news that the failure crate is being deprecated, and was aware this library is used by rust-bert: see rust-lang-deprecated/failure#347

This probably isn't a priority, but something you might want to be aware of at least.

@guillaume-be
Copy link
Owner

Hello,

I agree and have seen the news too. For now rust-bert relies on tch-rs which still uses Failure. I am keeping the dependency for a similar "feel" between the two libraries. I would recommend raising it to the tch-rs author. If required the Failure crate is only lightly used and replacing the Faillible<()> by Result<T, Err> should not require too much effort.

Thank you for raising this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants