Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail with Test-Simple-0.98_05 #1

Closed
ppisar opened this issue Jul 24, 2013 · 4 comments
Closed

Tests fail with Test-Simple-0.98_05 #1

ppisar opened this issue Jul 24, 2013 · 4 comments
Assignees
Milestone

Comments

@ppisar
Copy link

ppisar commented Jul 24, 2013

[test@fedora-20 Test-Dist-VersionSync-1.1.1]$ ./Build test
t/00-load.t ................................... 1/1 # Testing Test::Dist::VersionSync 1.1.1, Perl 5.018000, /usr/bin/perl
t/00-load.t ................................... ok
t/10-_get_modules_from_manifest-simple.t ...... ok
t/11-_get_modules_from_manifest-exclusions.t .. ok
t/20-ok_versions-sync.t ....................... 1/5
#   Failed test 'ok_versions() detects matching versions.'
#   at t/20-ok_versions-sync.t line 44.
# STDOUT is:
# ok 1 - No MANIFEST.SKIP found, skipping.
# ok 2 - The MANIFEST file is present at the root of the distribution.
# ok 3 - Retrieve MANIFEST file.
#     # Subtest: Retrieve versions for all modules listed.
#     1..4
#     ok 1 - use TestModule1;
#     ok 2 - Module TestModule1 declares a version.
#     ok 3 - use TestModule2;
#     ok 4 - Module TestModule2 declares a version.
# ok 4 - Retrieve versions for all modules listed.
# ok 5 - The modules declare only one version.
#
# not:
# ok 1 - No MANIFEST.SKIP found, skipping.
# ok 2 - The MANIFEST file is present at the root of the distribution.
# ok 3 - Retrieve MANIFEST file.
#     1..4
#     ok 1 - use TestModule1;
#     ok 2 - Module TestModule1 declares a version.
#     ok 3 - use TestModule2;
#     ok 4 - Module TestModule2 declares a version.
# ok 4 - Retrieve versions for all modules listed.
# ok 5 - The modules declare only one version.
#
# as expected
t/20-ok_versions-sync.t ....................... Failed 1/5 subtests

Obviously, the "Subtest: Retrieve versions for all modules listed." is missing in the output.

This fails with Test-Simple-0.98_05, it passes with Test-Simple-0.98.

@ppisar
Copy link
Author

ppisar commented Jul 24, 2013

It passes with Test-Simple-0.98_04. This is due this change in Test-Simple probably:

0.98_05  Tue Apr 23 17:33:51 PDT 2013
    New Features
    * A subtest will put its name at the front of its results to make
      subtests easier to read. [github #290] [github #364]
      (Brendan Byrd)

guillaumeaubert added a commit that referenced this issue Jul 24, 2013
From the changelog of Test::Simple:

0.98_05  Tue Apr 23 17:33:51 PDT 2013
    New Features
    * A subtest will put its name at the front of its results to make
      subtests easier to read. [github #290] [github #364]
      (Brendan Byrd)
@guillaumeaubert
Copy link
Owner

Thank you for noticing this! I just added a specific line for Test Simple with versions between 0.9805 included and v1.5 excluded (since it's unclear how/when it will be ported to the 1.5 branch).

@ghost ghost assigned guillaumeaubert Jul 24, 2013
@guillaumeaubert
Copy link
Owner

I'm going to bundle it with the other issue and release Test::Dist::VersionSync v1.1.2 shortly.

@guillaumeaubert
Copy link
Owner

Test::Dist::VersionSync v1.1.2 including this fix has been released. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants