Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail with Test-Simple-0.98_04 #2

Closed
ppisar opened this issue Jul 24, 2013 · 2 comments
Closed

Tests fail with Test-Simple-0.98_04 #2

ppisar opened this issue Jul 24, 2013 · 2 comments
Assignees
Milestone

Comments

@ppisar
Copy link

ppisar commented Jul 24, 2013

$ perl -Ilib -T t/22-ok_versions-modules_list.t 
1..5
ok 1 - use Cwd;
ok 2 - Change directory to t/22-ok_versions-modules_list.
ok 3 - Add the test lib/ directory to @INC.
not ok 4 - ok_versions() detects matching versions.
#   Failed test 'ok_versions() detects matching versions.'
#   at t/22-ok_versions-modules_list.t line 51.
# STDOUT is:
# ok 1 - 'modules list' isa 'ARRAY'
#     # Subtest: Retrieve versions for all modules listed.
#     1..4
#     ok 1 - use TestModule1;
#     ok 2 - Module TestModule1 declares a version.
#     ok 3 - use TestModule2;
#     ok 4 - Module TestModule2 declares a version.
# ok 2 - Retrieve versions for all modules listed.
# ok 3 - The modules declare only one version.
# 
# not:
# ok 1 - modules list isa ARRAY
#     # Subtest: Retrieve versions for all modules listed.
#     1..4
#     ok 1 - use TestModule1;
#     ok 2 - Module TestModule1 declares a version.
#     ok 3 - use TestModule2;
#     ok 4 - Module TestModule2 declares a version.
# ok 2 - Retrieve versions for all modules listed.
# ok 3 - The modules declare only one version.
# 
# as expected
ok 5 - Change back to the original directory.

Test-Simple-0.98_4 started quoting test names:

0.98_04  Sun Apr 14 10:54:13 BST 2013
     Feature Changes
    * The default name and diagnostics for isa_ok() and new_ok() have
      changed. (Michael G Schwern)
@ghost ghost assigned guillaumeaubert Jul 24, 2013
guillaumeaubert added a commit that referenced this issue Jul 24, 2013
From the changelog of Test::Simple:

0.98_04  Sun Apr 14 10:54:13 BST 2013
    Feature Changes
    * The default name and diagnostics for isa_ok() and new_ok() have
      changed. (Michael G Schwern)
@guillaumeaubert
Copy link
Owner

Thank you! Fixed for Test::Simple from 0.98_04 (included) to 1.5 (excluded). Hopefully the new way to do TAP::Formatter in 1.5 will eliminate those changes in output entirely.

@guillaumeaubert
Copy link
Owner

Test::Dist::VersionSync v1.1.2 including this fix has been released. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants