Clipping feature is implemented

[sariug]

Hello Guillaume,

As I stated in #186 I implemented clipping feature. Here is the screenshots:

I tried following the documentation and coding style as much as possible.
Let me know for open issues, as well as bugs you think.

Best regards,

[guillaumechereau]

Thanks, I'll have a look as soon as I can!

[guillaumechereau]

I just had a look. What is the use case for it that cannot be done with a selection? The ability to clip at an angle is interesting, but this could maybe be done by the selection directly.

[sariug]

Its been quite a while since i opened this pr. Thanks for looking at it.

We were using goxel for visualizing outcomes of our operations, and to decide on new operations on some scientific software. in order to implement good ways and angles, it was necessary to be able to have sharp cuts depending on precise normals and precise points.

If i remember correct, the selection tool gives us not enough freedom and precision to have these visualization as quickly as we want.

Also just realized, the code is quite unformatted and probably there exists merge conflicts. I will fix them once you make your mind :)

[guillaumechereau]

Nice to see that goxel is used in scientific software! I would be curious to know more about that.

The way I see it I could add support for non aligned box selection, or non align snapping plane (in the 'plane' tool). Maybe both? I think doing it with the plane first is probably the easiest and should allow to do the clipping your branch is doing, without having to modify the layers UI.

It shouldn't be too hard to modify the plane tool to put the same rotation parameters you have in your branch I think, and add a 'clip' button there as well.

I'll check a bit more your commits to see what I can do from it.

[guillaumechereau]

A quick test of supporting planes at custom angles seems to work more or less, as shown on this screenshot. There are a a few weird things happening that should be fixed, but I think that would not be too difficult. Would something like that work for your use case?

[sariug]

I played with it a little bit. It seems to be doing the same job.
But it would be really nice to be able to create new layers from different pieces since the model would be pretty big and one would need only hide/show pieces. Think goxel as an investigation tool rather than creation tool. But thanks for the quick modification!

[guillaumechereau]

Indeed. I think the best would be to make it work like the fuzzy select tool, where you first make a selection, and then have different possible actions to act on it, including cutting to a new layer. I'll probably change it like that.