ZRANGEBYLEX and ZREVRANGEBYLEX commands support #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| range = get_range start, stop, sorted.first, sorted.last | ||
|
|
||
| filtered = [] | ||
| sorted.each do |element| |
There was a problem hiding this comment.
instead of traversing the sorted array, maybe you could use Array#bsearch for searching the beginning and ending positions.
There was a problem hiding this comment.
good point. I'll take a look asap
There was a problem hiding this comment.
@larrylv
I don't think #bsearch is suitable there. I don't find border elements there, I check each element for range condition.
I handle begin and end positions there
https://github.com/guilleiguaran/fakeredis/pull/135/files#diff-dd66f1d97e61bf36103779390dbe90c9R975
* master: fix doc that minitest is not rspec Return correct 1 or 0 for hash set functions hscan method returns empty array when key is not found add hscan method return 0 for lrem if key does not exist (as expected - http://redis.io/commands/lrem) fix namespace conflict for minitest add zscan_each + specs refactor key-value sorting into method add zscan + specs Stub Time.now when checking key expiry time in ms Update expiry conditional to be inclusive yeah, thats nicer adding guard add fake blocking User correct redis-rb repo Add BITOP command Add support for Minitest configuration. disallow pushing empty list of objects
guilleiguaran
added a commit
that referenced
this pull request
Nov 25, 2015
ZRANGEBYLEX and ZREVRANGEBYLEX commands support
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. I added support to 2 new commands
Also stable redis-rb doesn't support all these features well (see redis/redis-rb#492)
Comments are welcome